Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set RUST_LOG for aardvark and keep aardvark stderr open with debug log level #218

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Feb 10, 2022

set RUST_LOG for aardvark

keep aardvark stderr open with debug log level

It is important to read stderr output from aardvark to debug things like
panics. Since keeping the stderr open can cause EPIPE when aardvark tries
to write to it and the user closed the original stderr, this is only done
for debug/trace level.

Signed-off-by: Paul Holzinger <[email protected]>
It is important to read stderr output from aardvark to debug things like
panics. Since keeping the stderr open can cause EPIPE when aardvark tries
to write to it and the user closed the original stderr, this is only done
for debug/trace level.

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baude
Copy link
Member

baude commented Feb 10, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 10, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6d59e4e into containers:main Feb 10, 2022
@Luap99 Luap99 deleted the env branch February 10, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants